Fix deps *brave_process* target in //brave/browser/ #6831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gyuyoung
commented
Oct 12, 2020
browser/sources.gni
Outdated
| @@ -4,9 +4,49 @@ | |||
| # You can obtain one at http://mozilla.org/MPL/2.0/. | |||
|
|
|||
| import("//brave/browser/importer/sources.gni") | |||
| import("//brave/components/binance/browser/buildflags/buildflags.gni") | |||
| import("//third_party/widevine/cdm/widevine.gni") | |||
There was a problem hiding this comment.
This PR needs to include widevine.gni to use enable_widevine guard in line #45. But, it causes below import loop error.
FAILED: build.ninja
../../buildtools/linux64/gn --root=../.. -q gen .
ERROR //build/config/chrome_build.gni is part of an import loop.
See //brave/browser/sources.gni:8:1: whence it was imported.
import("//third_party/widevine/cdm/widevine.gni")
^-----------------------------------------------
See //brave/build/config/brave_build.gni:6:1: whence it was imported.
import("//brave/browser/sources.gni")
^-----------------------------------
See //build/config/chrome_build.gni:4:1: whence it was imported.
import("//brave/build/config/brave_build.gni")
^--------------------------------------------
See //build/config/compiler/compiler.gni:5:1: whence it was imported.
import("//build/config/chrome_build.gni")
^---------------------------------------
See //BUILD.gn:11:1: whence it was imported.
import("//build/config/compiler/compiler.gni")
^--------------------------------------------
ninja: error: rebuilding 'build.ninja': subcommand failed
Gyuyoung
force-pushed
the
gyuyoung-brwoser-process-target
branch
from
bf80c8f
to
e2d2a64
Compare
Gyuyoung
force-pushed
the
gyuyoung-brwoser-process-target
branch
from
e2d2a64
to
00e0519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#12084.
Resolves
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).QA/YesorQA/No) to the associated issuerelease-notes/includeorrelease-notes/exclude) to the associated issueTest Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.